Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] Fix off by one error #2180

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[ARM] Fix off by one error #2180

merged 1 commit into from
Oct 23, 2023

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Oct 22, 2023

LLVM checks the operand OpNum + 1 (but it is named MO2). Hence the mistake.

This can lead to a missing index register in detail.

@Rot127
Fix off by one error.
6035d55 
LLVM checks the operand OpNum + 1 (but it is named MO2).
Hence the mistake.
@Rot127 Rot127 mentioned this pull request Oct 22, 2023
Merged
5 tasks
@XVilka
Copy link
Contributor

XVilka commented Oct 23, 2023

@kabeor please take a look

@XVilka
Copy link
Contributor

XVilka commented Oct 23, 2023

@aquynh take a look please

@kabeor
Copy link
Member

kabeor commented Oct 23, 2023

Merged, thanks.

@kabeor kabeor merged commit 4834d19 into capstone-engine:next Oct 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rot127 @XVilka @kabeor