Fix incorrect setup of mnemonic and op_str field.
#2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
force-pushed
the
missing-mnemonic
branch
2 times, most recently
from
f710dc4
to
0e1be18
Compare
Rot127
force-pushed
the
missing-mnemonic
branch
from
0e1be18
to
1f32e60
Compare
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some alias instructions have a leading space or tab in the asm text (no idea why LLVM does that). Because of that the mnemonic and op_str were never properly separated, because stops looking for the mnemonic at the first tab/space occurrence.
So we simply check for leading blank chars in the asm text and remove them.
closes #2189