Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Move meta-programming macros for ARM64/AArch64 to capstone.h #2201

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Nov 17, 2023

Move the meta-programming macros for ARM64 -> AArch64 name change to capstone.h so it is consistent with #2199 and #2200

@Rot127 Rot127 changed the title Move meta-programming macros for ARM64/AArch64 to capstone.h [v6] Move meta-programming macros for ARM64/AArch64 to capstone.h Nov 17, 2023
@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

Add some tests plz:)

@Rot127
Copy link
Collaborator Author

Rot127 commented Nov 19, 2023

I could add a CI test to run the pre-processor step on some dummy file which uses those macros. Though it feels a little over-engineered to me. Do you have a better idea?

Generally though we use these macros in Rizin. And we build Rizin with v4, v5 and now v6 in our CI. So they are tested there and I'll detect errors.

@Rot127
Copy link
Collaborator Author

Rot127 commented Nov 19, 2023

Or a dummy program which uses them. And we compile it for v4 and on.

@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

Ah I just thought we can copy test_aarch64.c and rename all aarch64 to arm64, which is simple and effective. How do you think?

By the way, I found test_aarch64 binary is merged into the repository.

@Rot127
Copy link
Collaborator Author

Rot127 commented Nov 19, 2023

test_aarch64 is a good idea! I'll remove the binary here.

@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

Thanks,the binary should be completely purged from the whole commits history. Or the repository size will increase with the accumulation of new commits.

@Rot127
Copy link
Collaborator Author

Rot127 commented Nov 20, 2023

@kabeor Please check again.

@kabeor
Copy link
Member

kabeor commented Nov 24, 2023

Cool, merged.

@kabeor kabeor merged commit 6220595 into capstone-engine:next Nov 24, 2023
11 checks passed
@Rot127 Rot127 added this to the v6 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants