Disable maybe-uninitialized warning all together. #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
force-pushed
the
maybe-uninitialized
branch
from
af20093
to
aa28b3e
Compare
|
@kabeor Might it be possible that you find time soon to look at this? It is the only thing left which keeps us from merging in Rizin. Hence, I would really appreciate it :) |
|
Sure, I think it's make sense. Merged, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling
maybe-unitialized(which produces false positives) is really annoying if done in code withpragmas.The option is only supported by a certain subset of
gccversions and all the other compilers throw warnings about an unknown option.I do not think it is worth it and we should disable it for the whole project.