Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto-Sync] LLVM 18 update #2296

Merged
merged 41 commits into from
Apr 22, 2024
Merged

[Auto-Sync] LLVM 18 update #2296

merged 41 commits into from
Apr 22, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Mar 21, 2024

SQUASH ME

commit message:

Refactor auto-sync updater

This refactors the auto-sync updater scripts, adds multiple tests and some other smaller things:

- Converts the updater in a proper Python package.
- Renaming was done to fit this new package structure.
- Format code with usort and black and enforce it with the CI.
- Add license information to auto-sync scripts.
- Update tree-sitter-cpp to v20.0.5
- Fix py-tree-sitter version to `< 0.22.0` due to https://github.com/tree-sitter/tree-sitter-cpp/issues/250
- Allow file/dir creation of non existing paths.
- Add CI tests for Patch, inc gen, translation and diff persistence testing.
- Implement editing of diffs with an editor.
- Fix: Add Namespace id also to anonymous enumeration members.

Your checklist for this pull request

  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

For now only fixups and tests for the AS scripts. No changes to the archs

  • Add a Capstone diet build test With arch updates.

Test plan

CI green

Closing issues

...

@Rot127 Rot127 force-pushed the as-18-update branch 10 times, most recently from 912378f to 038e1af Compare March 21, 2024 11:12
@Rot127 Rot127 marked this pull request as ready for review March 25, 2024 06:55
@Rot127
Copy link
Collaborator Author

Rot127 commented Mar 25, 2024

@kabeor Also please take a look at this one. I will add more tests, but implement them together with the arch updates (each in separated PRs).

But this makes already many changes. No need to stack them indefinitely.

@Rot127
Copy link
Collaborator Author

Rot127 commented Mar 25, 2024

@kabeor When you merge, please squash and use the commit message from above

@Rot127 Rot127 mentioned this pull request Mar 25, 2024
6 tasks
@Rot127
Copy link
Collaborator Author

Rot127 commented Apr 7, 2024

@kabeor Can you please take a look at it. It does a lot of clean ups.

@kabeor
Copy link
Member

kabeor commented Apr 7, 2024

Thanks a lot. I have started the review, will done asap.

@Rot127 Rot127 added this to the v6 milestone Apr 7, 2024
@Rot127 Rot127 mentioned this pull request Apr 20, 2024
5 tasks
@kabeor
Copy link
Member

kabeor commented Apr 22, 2024

Really nice! Thanks a lot!

@kabeor kabeor merged commit 7746648 into capstone-engine:next Apr 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants