Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt version (See #2310) #2311

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Update CMakeLists.txt version (See #2310) #2311

merged 1 commit into from
Apr 22, 2024

Conversation

PerikiyoXD
Copy link

@PerikiyoXD PerikiyoXD commented Apr 7, 2024 •
edited by Rot127
Loading

Explanation found on #2310

closes #2310

@PerikiyoXD
Copy link
Author

I don't really know which target branch is the one it should go in, went with default one.

@Rot127 Rot127 added the build & packaging Build system and packaging related label Apr 7, 2024
@Rot127 Rot127 added this to the v5.0.2 milestone Apr 7, 2024
@Rot127 Rot127 changed the base branch from next to v5 April 7, 2024 05:06
@Rot127 Rot127 changed the base branch from v5 to next April 7, 2024 05:06
Rot127
Rot127 requested changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this on the v5 branch. It should be part of the v5.0.2 release.

@Rot127
Copy link
Collaborator

Rot127 commented Apr 7, 2024

Also, please fill out the complete PR description template next time. In this case it is ok, because the change is so small. But we require it for everything non-trivial.

@PerikiyoXD PerikiyoXD changed the base branch from next to v5 April 7, 2024 10:50
@PerikiyoXD
Copy link
Author

Please rebase this on the v5 branch. It should be part of the v5.0.2 release.

Rebased

@PerikiyoXD PerikiyoXD requested a review from Rot127 April 7, 2024 11:45
@kabeor
Copy link
Member

kabeor commented Apr 22, 2024

Thanks, merged.

@kabeor kabeor merged commit 911b15c into capstone-engine:v5 Apr 22, 2024
6 checks passed
This was referenced Apr 22, 2024
Closed
Closed
@PerikiyoXD PerikiyoXD deleted the patch-1 branch April 24, 2024 03:40
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

@Rot127 Rot127 Rot127 approved these changes

Assignees
No one assigned
Labels
build & packaging Build system and packaging related
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.

Use proper versioning on CMakeLists.txt - pkgconf versions are wrong otherwise
3 participants
@PerikiyoXD @Rot127 @kabeor