Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if decode[idx] is callable #2322

Merged
merged 2 commits into from
Apr 23, 2024
Merged

check if decode[idx] is callable #2322

merged 2 commits into from
Apr 23, 2024

Conversation

Ced2911
Copy link
Contributor

@Ced2911 Ced2911 commented Apr 12, 2024

idx can be bigger than 256, this pr will check the size of decode before calling it

@github-actions github-actions bot added the SH Arch label Apr 12, 2024
Rot127
Rot127 requested changes Apr 15, 2024
View reviewed changes
arch/SH/SHDisassembler.c Outdated Show resolved Hide resolved
kabeor
kabeor approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kabeor kabeor merged commit e9284b6 into capstone-engine:next Apr 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

@Rot127 Rot127 Rot127 approved these changes

Assignees
No one assigned
Labels
SH Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ced2911 @kabeor @Rot127