Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Fix #2244: Don't apply pseudo-instr. offset to vcmp id #2331

Merged
merged 1 commit into from
May 8, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Apr 24, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

There is an offset for instruction IDs, which get applied to some of them.
For vcmp it seems they get applied incorrectly though.

Test plan

Added

Closing issues

closes #2244

@github-actions github-actions bot added the CS-core-files auto-sync label Apr 24, 2024
@Rot127 Rot127 changed the title Fix #2244: Don't apply pseudo-instr. offset to vcmp id [next] Fix #2244: Don't apply pseudo-instr. offset to vcmp id Apr 24, 2024
@Rot127 Rot127 added the X86 Arch label Apr 24, 2024
@Rot127 Rot127 added this to the v6 milestone Apr 24, 2024
@github-actions github-actions bot removed the X86 Arch label Apr 30, 2024
@Rot127 Rot127 marked this pull request as draft April 30, 2024 06:57
@Rot127 Rot127 marked this pull request as ready for review April 30, 2024 06:57
@XVilka
Copy link
Contributor

XVilka commented May 7, 2024

@kabeor and this one

@kabeor kabeor merged commit 1a65b8d into capstone-engine:next May 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS-core-files auto-sync
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[x86] pseudo opcode adjustment for vcmpnlesd is wrong to vcompresspd
3 participants