Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static lib (#2433) #2434

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix static lib (#2433) #2434

merged 1 commit into from
Aug 12, 2024

Conversation

hsebs
Copy link

@hsebs hsebs commented Aug 11, 2024 •
edited by Rot127
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

  • mapping.c is missing.

Test plan

...

Closing issues

closes #2433
closes #2177

@Rot127 Rot127 added the build & packaging Build system and packaging related label Aug 11, 2024
@Rot127 Rot127 modified the milestones: v5.0.2, v5.0.3 Aug 11, 2024
kabeor
kabeor approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kabeor kabeor merged commit 4587622 into capstone-engine:v5 Aug 12, 2024
16 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
@Rot127 Rot127 mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

@Rot127 Rot127 Rot127 approved these changes

Assignees
No one assigned
Labels
build & packaging Build system and packaging related
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@hsebs @kabeor @Rot127