Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemZ Auto-Sync refactor #2462

Merged
merged 71 commits into from
Sep 14, 2024
Merged

SystemZ Auto-Sync refactor #2462

merged 71 commits into from
Sep 14, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Aug 28, 2024 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Based on: #2456

Detailed description

Refactors the SystemZ module.

New features:

  • Update to LLVM-18
  • Memory operands have now an address mode attached to see which fields are set.
  • Instruction formats are added.
  • Operand access information is added.

Changes

  • Renaming SysZ to SystemZ everywhere and adding a compatibility header for it.

Bug fixes

  • pintInt functions were not working for INTx_MIN values.
  • Added several unit tests
  • Adding support to annotate the the output stream.
  • Check for overflows in the stream.

Test plan

Added

Closing issues

closes #2423
closes #1545
closes #2194

@Rot127 Rot127 mentioned this pull request Aug 28, 2024
Open
47 tasks
@Rot127
Delete unused files.
084c979
@Rot127
Fix faulty name in header.
14812b5
@Rot127
Add SystemZ compatibility header and tests.
143db74
@Rot127
Add missing modes
4aee98d
@Rot127
Fix markup tests and add overflow unit tests
1deb92b
@Rot127
Update saved patches and fix Differ if new node is first.
78da233
@Rot127
Add SystemZ to Auto-Sync test
4846c3c
@Rot127
Fix value of CS_ARCH_SYSTEMZ in Python bindings
2737940
@Rot127
Make multiple test files with same byte input the default.
5e5967f
@Rot127
Fix gcc warning
8c1aecb
@Rot127
Fix: Remove access to non existent attribute.
c1d82b5
@Rot127
Update v6 release notes with SystemZ renaming instructions
ad6831d
@Rot127
Formatting
42f5bd5
@Rot127
Fix signed printing with printInt8 and printInt16
a419d27
@Rot127
Reintroduce mutex
0006f11
@Rot127
Fix printing of minimal signed integer values in hex.
e7b22a8 
This also adds several tests and simplifications.
@Rot127
Run correct integration tests in CI
20a15df
@Rot127
Formatting
483ab77
@Rot127
Remove check for saved diffs, since it doesn't produce reproducable r…
c99d819 
…esults.
@Rot127 Rot127 force-pushed the SysZ-AS-refactor branch 2 times, most recently from 169777d to 0615bdc Compare September 9, 2024 10:35
kabeor
kabeor approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool!

@kabeor kabeor merged commit af1ed2f into capstone-engine:next Sep 14, 2024
19 checks passed
@Rot127 Rot127 deleted the SysZ-AS-refactor branch September 15, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
ARM Arch Auto-Sync-files Auto-Sync CS-core-files auto-sync Documentation Github-files Github related files LLVM-core-files auto-sync LLVM-generated-files python bindings SystemZ Arch
Projects
None yet
Milestone
No milestone
2 participants
@Rot127 @kabeor