Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert with CS_ASSERT in modules #2478

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Replace assert with CS_ASSERT in modules #2478

merged 6 commits into from
Sep 25, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Sep 11, 2024 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Replaces assert with CS_ASSERT in all module code.

This does not replace all asserts. Especially not the once which do bound checking.

Test plan

All green

Closing issues

...

@Rot127 Rot127 mentioned this pull request Sep 14, 2024
Merged
2 tasks
@github-actions github-actions bot removed X86 Arch M680X Arch M68K Arch MOS65XX Arch RISCV Arch SH Arch WASM Arch Documentation Github-files Github related files labels Sep 24, 2024
kabeor
kabeor approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged

@kabeor kabeor merged commit 0c90fe1 into capstone-engine:next Sep 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
AArch64 Arch Alpha Arch ARM Arch Auto-Sync-files Auto-Sync BPF Arch CS-core-files auto-sync HPPA Arch LLVM-core-files auto-sync LLVM-generated-files LoongArch Arch Mips Arch PowerPC Arch python bindings Sparc Arch SystemZ Arch TriCore Arch XCore Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @kabeor