Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumps and branches on a non-zero PC #2479

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

wargio
Copy link
Contributor

@wargio wargio commented Sep 14, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fix jumps and branches on a non-zero PC

Test plan

Added tests to ensure jumps are correct.

@github-actions github-actions bot added the Mips Arch label Sep 14, 2024
arch/Mips/MipsDisassembler.c Outdated Show resolved Hide resolved
arch/Mips/MipsDisassembler.c Outdated Show resolved Hide resolved
@wargio wargio requested a review from Rot127 September 17, 2024 05:07
@wargio wargio changed the title Fix mips jumps with base/virtual address Fix jumps and branches on a non-zero PC Sep 17, 2024
@wargio
Copy link
Contributor Author

wargio commented Sep 18, 2024

@kabeor

@wargio
Copy link
Contributor Author

wargio commented Sep 18, 2024

Fixed the conflict. @kabeor

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kabeor kabeor merged commit e9b9b64 into capstone-engine:next Sep 19, 2024
19 checks passed
@wargio wargio deleted the mips-jump-branch-addr branch September 20, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mips Arch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants