Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing UB santizer, LITBASE and assert errors. #2499

Merged
merged 8 commits into from
Oct 6, 2024
Merged

Fixing UB santizer, LITBASE and assert errors. #2499

merged 8 commits into from
Oct 6, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Oct 5, 2024 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes several sanitizer and debug reaches.

  • Always build Capstone as Debug in CI. To hit asserts.
  • Setup env variables to ensure ASAN, UBSAN and LSAN abort on failure.
  • Fix UB in printInt32 for INT32_MIN
  • Fix UB for AArch64, ARM, HPPA
  • Fix Xtensa reachable assert.
  • Fix incorrect Xtensa LITBASE handling.

Test plan

All green (test cases were already added)

Closing issues

...

@github-actions github-actions bot added CS-core-files auto-sync Github-files Github related files labels Oct 5, 2024
@Rot127
Fix Xtensa reachable assert.
9d95d9e 
The immediate given to decodeImm8_sh8Operand has been already shifted.
Checking if it is an 8bit value fails therefore.
@github-actions github-actions bot added ARM Arch AArch64 Arch HPPA Arch labels Oct 5, 2024
@Rot127 Rot127 changed the title Fix asserts and always build debug binaries in CI. Fixing santizer bugs. Oct 5, 2024
@Rot127 Rot127 changed the title Fixing santizer bugs. Fixing UB santizer errors. Oct 5, 2024
@Rot127 Rot127 changed the title Fixing UB santizer errors. Fixing UB santizer, LITBASE and assert errors. Oct 5, 2024
kabeor
kabeor approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged

@kabeor kabeor merged commit 52b54ee into capstone-engine:next Oct 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
AArch64 Arch ARM Arch CS-core-files auto-sync Github-files Github related files HPPA Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @kabeor