Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcyaml dependency in cstest to 1.4.2 #2508

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

thestr4ng3r
Copy link
Contributor

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

1.4.2 contains a fix to replace static_assert calls by a more portable variant. This is relevant for building on e.g. Mac OS X 10.5.

Test plan

Build with MacPorts gcc 7.5.0 on Mac OS X 10.5 and -DCAPSTONE_BUILD_CSTEST=1. (Hint: there are other issues in the cstest code, but those can be addressed separately)

1.4.2 contains a fix to replace static_assert calls by a more portable
variant. This is relevant for building on e.g. Mac OS X 10.5.
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint: there are other issues in the cstest code, but those can be addressed separately

Which one? Can you open an issue about please.

@thestr4ng3r
Copy link
Contributor Author

Hint: there are other issues in the cstest code, but those can be addressed separately

Which one? Can you open an issue about please.

strndup usage, opened an issue: #2517

@XVilka
Copy link
Contributor

XVilka commented Oct 16, 2024

@kabeor and this one

@Rot127
Copy link
Collaborator

Rot127 commented Oct 17, 2024

strndup usage, opened an issue: #2517

Alright. Thanks for the issue! I didn't make it portable (also not for Windows) because it took too much time already. And with cstest_py we can technically still test everything on all platforms. Another one is the dir walking. Also doesn't work Windows I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants