Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate of #2590 for v5 Branch #2596

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

AndrewQuijano
Copy link
Contributor

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

This is a duplicate of #2590

...

Test plan

This is a duplicate of #2590
...

Closing issues
N/A
...

@AndrewQuijano AndrewQuijano force-pushed the cpack-v5 branch 8 times, most recently from 427dc0b to f24ad82 Compare January 13, 2025 18:34
@AndrewQuijano
Copy link
Contributor Author

@Rot127 Please merge this too, figure doesn't hurt to double-check this works too, and please create a new release @kabeor

Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still misses the shared libraries. Only has libcapstone.a:

rpm -ql ./capstone-devel-v200.0.0.x86_64.rpm 
/usr/bin/cstool
/usr/include/capstone
/usr/include/capstone/arm.h
/usr/include/capstone/arm64.h
/usr/include/capstone/bpf.h
/usr/include/capstone/capstone.h
/usr/include/capstone/evm.h
/usr/include/capstone/m680x.h
/usr/include/capstone/m68k.h
/usr/include/capstone/mips.h
/usr/include/capstone/mos65xx.h
/usr/include/capstone/platform.h
/usr/include/capstone/ppc.h
/usr/include/capstone/riscv.h
/usr/include/capstone/sh.h
/usr/include/capstone/sparc.h
/usr/include/capstone/systemz.h
/usr/include/capstone/tms320c64x.h
/usr/include/capstone/tricore.h
/usr/include/capstone/wasm.h
/usr/include/capstone/x86.h
/usr/include/capstone/xcore.h
/usr/lib/.build-id
/usr/lib/.build-id/92
/usr/lib/.build-id/92/7752daf27dde5a87dac4f5068d1e46cd0f6ec2
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/cmake
/usr/lib/x86_64-linux-gnu/cmake/capstone
/usr/lib/x86_64-linux-gnu/cmake/capstone/capstone-config-version.cmake
/usr/lib/x86_64-linux-gnu/cmake/capstone/capstone-config.cmake
/usr/lib/x86_64-linux-gnu/cmake/capstone/capstone-targets-release.cmake
/usr/lib/x86_64-linux-gnu/cmake/capstone/capstone-targets.cmake
/usr/lib/x86_64-linux-gnu/libcapstone.a
/usr/lib/x86_64-linux-gnu/pkgconfig
/usr/lib/x86_64-linux-gnu/pkgconfig/capstone.pc

@Rot127
Copy link
Collaborator

Rot127 commented Jan 14, 2025

Please merge this too, figure doesn't hurt to double-check this works too, and please create a new release @kabeor

I don't have the privilege to merge PRs or create releases on my own. @kabeor needs to review and approve first and then find time to create the release.

@AndrewQuijano
Copy link
Contributor Author

AndrewQuijano commented Jan 14, 2025

@Rot127 I fixed the issue, it was CAPSTONE_BUILD_SHARED_LIB vs BUILD_SHARED_LIB, @kabeor could you please create v5.0.4 before Lunar New Year?

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. @Rot127 It would be wonderful if you have time to check the issue you mentioned above again.

Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rot127 Rot127 merged commit 44b0589 into capstone-engine:v5 Jan 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants