Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Support #69

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Tag Support #69

merged 1 commit into from
Apr 4, 2018

Conversation

atticoos
Copy link
Contributor

@atticoos atticoos commented Apr 4, 2018

This adds support for tags:

createRavenMiddleware(Raven, {
  getTags: () => ({foo: 'foo', bar: 'bar'})
})

Nothing crazy, it just adds a tags field to data (data.tags = getTags(state))

Screenshot from running this example:

screen shot 2018-04-04 at 4 44 34 pm

@codecov-io
Copy link

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #69   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          24     26    +2     
  Branches        9     10    +1     
=====================================
+ Hits           24     26    +2
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44292fc...2b7376d. Read the comment docs.

@captbaritone
Copy link
Owner

Nice looks good! I'll try to find some time to add this to the documentation in the readme, and cut a new release.

@captbaritone captbaritone merged commit 3af894b into captbaritone:master Apr 4, 2018
@captbaritone
Copy link
Owner

Actually, would you mind taking a stab at adding some docs to the README.md?

@atticoos
Copy link
Contributor Author

atticoos commented Apr 4, 2018

Happy to -- I originally meant to and totally forgot 😄

Added to my reminders for tomorrow.

@atticoos atticoos mentioned this pull request Apr 5, 2018
@captbaritone
Copy link
Owner

Shipped in 1.3.1 (I had already published 1.3.0 but forgotten to push the version bump to GitHub)

@atticoos
Copy link
Contributor Author

atticoos commented Apr 5, 2018

Thanks for the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants