feat: add webhook call to other events #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
- Coverage 60.77% 60.68% -0.09%
==========================================
Files 276 277 +1
Lines 22205 22245 +40
==========================================
+ Hits 13494 13500 +6
- Misses 7847 7877 +30
- Partials 864 868 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bayu-aditya
reviewed
Oct 8, 2024
bayu-aditya
reviewed
Oct 8, 2024
tiopramayudi
reviewed
Oct 9, 2024
bthari
force-pushed
the
add-event-webhook
branch
from
e097e56 to
8df6574
Compare
tiopramayudi
approved these changes
Oct 15, 2024
|
Thank you for the review and feedback @tiopramayudi @bayu-aditya! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously on #601 I added webhook for model version endpoint related event, and in here the event will be expanded into a model, model endpoint, model version related event, as we also want to have an action (from other service) to be triggered if these events happen.
Modifications
on-model-version-*toon-version-endpoint-*Tests
Checklist
Notes for Reviewer
The version of MLP used here has a validation bug (which is updated on MLP#117). The code could still work with workaround (e.g. set
FinalResponse: truein one async webhook if user use all async webhook, but it will be confusing for user since async webhook response is expected to not be used anywhere),so preferably to merge this PR after updating the MLP version as dependencies.(MLP version will be updated with the s3 PR)Release Notes