Skip to content

Commit

Permalink
Update streamlit configs
Browse files Browse the repository at this point in the history
  • Loading branch information
deadlycoconuts committed Jul 25, 2024
1 parent 8a29a49 commit b071d63
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
5 changes: 2 additions & 3 deletions api/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,8 @@ type UIConfig struct {
StaticPath string `validated:"required"`
IndexPath string `validated:"required"`

ClockworkUIHomepage string `json:"REACT_APP_CLOCKWORK_UI_HOMEPAGE"`
KubeflowUIHomepage string `json:"REACT_APP_KUBEFLOW_UI_HOMEPAGE"`
CaramlAIStreamlitHomepage string `json:"REACT_APP_CARAML_AI_STREAMLIT_HOMEPAGE"`
ClockworkUIHomepage string `json:"REACT_APP_CLOCKWORK_UI_HOMEPAGE"`
KubeflowUIHomepage string `json:"REACT_APP_KUBEFLOW_UI_HOMEPAGE"`

AllowCustomStream bool `json:"REACT_APP_ALLOW_CUSTOM_STREAM"`
AllowCustomTeam bool `json:"REACT_APP_ALLOW_CUSTOM_TEAM"`
Expand Down
15 changes: 10 additions & 5 deletions api/models/v2/application.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package models

type Application struct {
Name string `json:"name" validate:"required"`
Description string `json:"description"`
Homepage string `json:"homepage"`
Configuration *ApplicationConfig `json:"config" validate:"dive"`
IsProjectAgnostic bool `json:"is_project_agnostic"`
Name string `json:"name" validate:"required"`
Description string `json:"description"`
Homepage string `json:"homepage"`
Configuration *ApplicationConfig `json:"config" validate:"dive"`
IsProjectAgnostic bool `json:"is_project_agnostic"`
StreamlitPlaceholderPageConfig *StreamlitPlaceholderPageConfig `json:"streamlit_placeholder_page_config"`
}

type ApplicationConfig struct {
Expand All @@ -18,3 +19,7 @@ type NavigationMenuItem struct {
Label string `json:"label"`
Destination string `json:"destination"`
}

type StreamlitPlaceholderPageConfig struct {
StreamlitURL string `json:"streamlit_url"`
}
1 change: 0 additions & 1 deletion ui/packages/app/src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const config = {
),
CLOCKWORK_UI_HOMEPAGE: getEnv("REACT_APP_CLOCKWORK_UI_HOMEPAGE"),
KUBEFLOW_UI_HOMEPAGE: getEnv("REACT_APP_KUBEFLOW_UI_HOMEPAGE"),
CARAML_AI_STREAMLIT_HOMEPAGE: getEnv("REACT_APP_CARAML_AI_STREAMLIT_HOMEPAGE"),
ALLOW_CUSTOM_STREAM:
getEnv("REACT_APP_ALLOW_CUSTOM_STREAM") != null
? getEnv("REACT_APP_ALLOW_CUSTOM_STREAM")
Expand Down

0 comments on commit b071d63

Please sign in to comment.