Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Update all caraml ui-lib versions #107

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Jul 11, 2024

Context

This PR updates the versions of the CaraML ui-lib package that's referenced in the MLP UI package.

This PR also updates the AccordionForm component to no longer use react-sticky - this package has no longer been maintained for the past 6 years and no longer supports newer versions of node/react. A new replacement react-stickynode is used instead to perform the same thing:

Screen.Recording.2024-07-15.at.13.28.21.mov

@deadlycoconuts deadlycoconuts self-assigned this Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.14%. Comparing base (d1f1876) to head (74490e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          47       47           
  Lines        2443     2443           
=======================================
  Hits         1396     1396           
  Misses        851      851           
  Partials      196      196           
Flag Coverage Δ
api-test 57.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Jul 15, 2024
@deadlycoconuts deadlycoconuts requested a review from leonlnj July 15, 2024 05:35
@deadlycoconuts deadlycoconuts marked this pull request as ready for review July 15, 2024 05:37
@deadlycoconuts deadlycoconuts merged commit 41cc54b into caraml-dev:main Jul 15, 2024
10 checks passed
@deadlycoconuts deadlycoconuts deleted the bump_up_caraml_ui_lib branch July 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants