-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend reusable components #11
Conversation
7fed32e
to
17f3e99
Compare
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
17f3e99
to
202a9ed
Compare
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Can you please update the PR's description with the list of added/updated components? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Agree with @ariefrahmansyah that a quick doc about added components would be useful.
@tiopramayudi @ariefrahmansyah it just caught my attention, that CI here ignores lint
errors. Also, all the other jobs should probably have needs
on lint
job, so the pipeline would not be executed e2e if lint
job fails. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the version on package.json files to 1.1.0
:
- https://github.com/gojek/mlp/blob/main/ui/package.json#L3
- https://github.com/gojek/mlp/blob/main/ui/packages/app/package.json#L3
- https://github.com/gojek/mlp/blob/main/ui/packages/lib/package.json#L3
I also agree with @romanwozniak's suggestion, can you help add lint
as dependencies to other jobs in this PR?
Other than that, LGTM
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
I added |
|
Signed-off-by: Terence Lim <terencelimxp@gmail.com>
Signed-off-by: Terence Lim terencelimxp@gmail.com
Add more reusable components to the library for use in other MLP systems.
Components added: