Add new resource using project name #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
force-pushed
the
add-project-name-keto-resource
branch
from
e96639d to
f3735eb
Compare
pradithya
reviewed
Mar 12, 2021
| @@ -83,6 +83,7 @@ func TestProjectsService_CreateProject(t *testing.T) { | |||
|
|
|||
| projectResource := fmt.Sprintf(ProjectResources, tt.arg.Id) | |||
| projectSubResource := fmt.Sprintf(ProjectSubResources, tt.arg.Id) | |||
| projectNameResource := fmt.Sprintf(ProjectResources, tt.arg.Name) | |||
There was a problem hiding this comment.
Shouldn't you use ProjectSubResources ? With current one it will be something like resources:mlp:projects:my_project which doesn't include any resource under my_project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Keto policy expects projects in the form of
resources:mlp:projects:<project_id>but Feast expects projects in the form ofresources:mlp:projects:<project_name>.Related Feast code can be found here.
This PR simply adds an additional resource in the
upsertmethods to overcome this disparity.