Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PageNavigation to use useNavigate hook #63

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Update PageNavigation to use useNavigate hook #63

merged 2 commits into from
Oct 18, 2022

Conversation

krithika369
Copy link
Collaborator

@krithika369 krithika369 commented Oct 17, 2022 •
edited
Loading

Since the migration from @reach/router to react-router-dom in #56, this PR updates the last remaining component that's using the now invalid props.navigate to the useNavigate() hook.

Also removing the hasFocus property which is now no longer valid, from EuiContextMenuPanel.

@krithika369 krithika369 marked this pull request as draft October 17, 2022 10:18
@krithika369 krithika369 marked this pull request as ready for review October 18, 2022 00:24
@krithika369 krithika369 requested a review from a team October 18, 2022 00:25
romanwozniak
romanwozniak approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@romanwozniak romanwozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@krithika369 krithika369 merged commit efe5a1f into caraml-dev:main Oct 18, 2022
@krithika369 krithika369 deleted the update_page_navigation_comp branch October 18, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanwozniak romanwozniak romanwozniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @romanwozniak