Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version + Remove outdated prop from MLP UI app #65

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Update Go version + Remove outdated prop from MLP UI app #65

merged 3 commits into from
Oct 25, 2022

Conversation

krithika369
Copy link
Collaborator

@krithika369 krithika369 commented Oct 25, 2022 •
edited
Loading

The appIcon prop was removed from the Header component in an old PR: https://github.com/gojek/mlp/pull/15/files. This PR removes its usage from the codebase.

Additionally, the internal dependency golang.org/x/sys mod now expects a minimum of Go1.17, without which the CI job fails: https://github.com/gojek/mlp/actions/runs/3318163507/jobs/5481800377

Per the document:

Each major Go release is supported until there are two newer major releases

We already have Go 1.19. Bumping the Go version in the MLP API module to 1.18, to be consistent with other components like Merlin and Turing.

@krithika369 krithika369 requested a review from a team October 25, 2022 01:59
Krithika Sundararajan added 2 commits October 25, 2022 12:29
@krithika369 krithika369 removed the request for review from a team October 25, 2022 08:40
@krithika369 krithika369 marked this pull request as draft October 25, 2022 08:41
@krithika369 krithika369 changed the title Remove outdated appIcon header prop from MLP app Update Go version + Remove outdated prop from MLP UI app Oct 25, 2022
@krithika369 krithika369 self-assigned this Oct 25, 2022
@krithika369 krithika369 marked this pull request as ready for review October 25, 2022 09:50
@krithika369 krithika369 requested a review from a team October 25, 2022 09:50
deadlycoconuts
deadlycoconuts approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks for updating this!

@krithika369
Copy link
Collaborator Author

Thanks for the quick review, @deadlycoconuts. Merging.

@krithika369 krithika369 merged commit ccae675 into caraml-dev:main Oct 25, 2022
@krithika369 krithika369 deleted the remove_header_props branch October 25, 2022 12:06
@krithika369 krithika369 restored the remove_header_props branch November 22, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

Assignees

@krithika369 krithika369

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @deadlycoconuts