Fix lint errors #69
Merged
Fix lint errors #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karzuo
reviewed
Oct 31, 2022
karzuo
approved these changes
Oct 31, 2022
It's the canonical Golang naming convention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In the past, CI pipeline ignored lint errors, which resulted in a large number of such issues accumulated in the codebase of this repo:
This PR fixes all existing lint errors and updates the CI pipeline to use golangci/golangci-lint instead of deprecated golang/lint. Moving forward, any added lint error will cause CI pipeline failure.