Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional helper method to init Google Client from specified file path #79

Conversation

deadlycoconuts
Copy link
Contributor

Context

This MR is a very similar follow-up to #78 and introduces another helper method to init the Google client (with both service and user accounts) from a specified file path.

In particular this is needed in XP's Treatment Service because we specify a precise filepath using a custom environment variable (something other than GOOGLE_APPLICATION_CREDENTIALS) when initialising the Treatment Service as an experiment engine plugin in a Turing Router.

@deadlycoconuts deadlycoconuts added the enhancement New feature or request label Mar 29, 2023
@deadlycoconuts deadlycoconuts self-assigned this Mar 29, 2023
Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching and fixing this, @deadlycoconuts !

@deadlycoconuts deadlycoconuts merged commit c28dca2 into caraml-dev:main Mar 29, 2023
@deadlycoconuts deadlycoconuts deleted the add_method_to_init_google_client_from_file branch March 29, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants