Migrate MLP from gojek to caraml-dev organisation #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
force-pushed
the
migrate-to-caraml-dev-org
branch
from
9d7fede to
d3b948b
Compare
terryyylim
force-pushed
the
migrate-to-caraml-dev-org
branch
from
d3b948b to
cc2d37b
Compare
|
Also, update the image repository in the helm-chart as well? |
deadlycoconuts
approved these changes
Apr 11, 2023
Yes will do once this is merged! |
ariefrahmansyah
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR migrates the MLP repository from the gojek organisation (
gojek/mlp) to the new CaraML organisation (caraml-dev/mlp). We need to update certain dependencies that were pointing to the original repo (e.g. Docker image repositories, Go dependencies pointing togojek/mlp, etc.), and also the Go module paths fromgit.luolix.top/gojek/mlptogit.luolix.top/caraml-dev/mlpto reflect the new changes.Subsequently,
github.com/caraml-dev/merlinandgit.luolix.top/caraml-dev/turingwould need to be updated as well to reference this repository.Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: