Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mlflow service mock #83

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

zenovore
Copy link
Collaborator

@zenovore zenovore commented Apr 14, 2023

adding mlflow mock for Turing/Merlin unit test. Mock used for some cases where deletion failed for the Run or the Experiment. This mlflow mocks created in mlp repo so turing and merlin could use it for their unit test (to reduce redudancy)

@zenovore zenovore marked this pull request as ready for review April 18, 2023 04:30
@zenovore zenovore requested a review from deadlycoconuts April 18, 2023 04:30
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the mock! But one thing, could you make the PR description a bit more descriptive; that'll help understand why this mock is created here and say, not elsewhere :) Thanks!

@zenovore zenovore force-pushed the feat/mock-mlflowService branch from 9a8f88a to eacbbf6 Compare April 28, 2023 10:02
@zenovore zenovore merged commit 779530a into caraml-dev:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants