Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new methods to artifact interface: Read, write, parse url #92

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Add new methods to artifact interface: Read, write, parse url #92

merged 3 commits into from
Dec 8, 2023

Conversation

ariefrahmansyah
Copy link
Contributor

Add new methods to the artifact.Service interface to be used by Merlin's image builder improvement: caraml-dev/merlin#500

New methods:

  1. ReadArtifact
  2. WriteArtifact
  3. ParseURL which replace getGcsBucketAndLocation

krithika369
krithika369 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments. The rest LGTM. Thanks, Arief!

api/pkg/artifact/artifact.go Outdated Show resolved Hide resolved
api/pkg/artifact/artifact.go Show resolved Hide resolved
@ariefrahmansyah ariefrahmansyah merged commit 1755960 into main Dec 8, 2023
8 checks passed
@ariefrahmansyah ariefrahmansyah deleted the update-artifact-interface branch December 8, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krithika369 krithika369 krithika369 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ariefrahmansyah @krithika369