-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement webhooks library and perform webhook call on project event #96
Conversation
11d67df
to
137992f
Compare
c14b1d0
to
368fd35
Compare
45aafd7
to
ec1659c
Compare
@leonlnj thanks for the feedback, have addressed most of the changes, lmk what you think. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks much better (at least for me) now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new series of changes! 🚀 LGTM!
Ooops wait wait, there's one last thing - can you add the webhook calls to the |
@deadlycoconuts added |
cc88088
to
36280c9
Compare
36280c9
to
e94db85
Compare
Merging this now, thanks for the review @leonlnj and @deadlycoconuts |
Description
events
occur.How to use?
Config
struct. In the config file, define the event to webhook mapping for those events as required. For example, if projects need extra labels from an external source, we define the webhook config for theOnProjectCreated
eventThis method will initialize the webhook clients for each event type based on the mapping provided
InvokeWebhooks()
method in the caller code based on the event. For a more complete example, see hereProject Service changes
Note for reviewers