Add default values to docker_config when using pyfunc ensemblers

caraml-dev · Mar 7, 2022 · f2767fc · f2767fc
1 parent 3a3c310
commit f2767fc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/api/turing/api/deployment_controller.go b/api/turing/api/deployment_controller.go
@@ -3,6 +3,7 @@ package api
 import (
 	"encoding/json"
 	"errors"
+	"fmt"
 	"strings"
 
 	merlin "github.com/gojek/merlin/client"
@@ -240,10 +241,14 @@ func (c RouterDeploymentController) deployRouterVersion(
 				ProjectID: routerVersion.Ensembler.PyfuncConfig.ProjectID,
 			})
 		if err != nil {
-			return "", err
+			return "", fmt.Errorf("failed to find specified ensembler: %w", err)
 		}
 
-		pyfuncEnsembler = ensembler.(*models.PyFuncEnsembler)
+		castedEnsembler, ok := ensembler.(*models.PyFuncEnsembler)
+		if !ok {
+			return "", fmt.Errorf("failed to cast ensembler: %w", err)
+		}
+		pyfuncEnsembler = castedEnsembler
 	}
 
 	// Deploy the router version

diff --git a/api/turing/service/router_deployment_service.go b/api/turing/service/router_deployment_service.go
@@ -459,6 +459,8 @@ func (ds *deploymentService) buildEnsemblerServiceImage(
 		Timeout:         routerVersion.Ensembler.PyfuncConfig.Timeout,
 		Endpoint:        PyFuncEnsemblerServiceEndpoint,
 		Port:            PyFuncEnsemblerServicePort,
+		Env:             models.EnvVars{},
+		ServiceAccount:  "",
 	}
 
 	return nil