-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list router sdk #148
Merged
deadlycoconuts
merged 18 commits into
caraml-dev:main
from
deadlycoconuts:add_list_router_sdk
Jan 7, 2022
Merged
Add list router sdk #148
deadlycoconuts
merged 18 commits into
caraml-dev:main
from
deadlycoconuts:add_list_router_sdk
Jan 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanwozniak
reviewed
Jan 5, 2022
romanwozniak
reviewed
Jan 5, 2022
romanwozniak
reviewed
Jan 5, 2022
romanwozniak
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now 🚀
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently the Turing SDK only supports batch experiments by covering only operations related to ensemblers and ensembling jobs, and we are now expanding its scope to cover online experiments by extending the SDK to cover operations involving other Turing components.
Changes:
This PR involves implementing a functionality corresponding to one of the API endpoints involving routers, i.e. listing the routers belonging to a given project.
Router
has been created for users to interact with (this interface exposes some attributes such asid
,name
,project_id
,config
, etc.)ExperimentConfig
has been changed to remove usage of theoneOf
keyword, which isn't currently supported by the OpenAPI generatorRouter
and its constituent components have been modified slightly to allow fornull
responses and other minor schema differencesRouter
class'list
method with its corresponding test fixtures (which can be reused when extending the SDK to other components)Note that the massive number of new line additions stem from the autogenerated OpenAPI classes.