Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated kube state metrics from the alerts #209

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Update deprecated kube state metrics from the alerts #209

merged 1 commit into from
Jun 10, 2022

Conversation

krithika369
Copy link
Collaborator

@krithika369 krithika369 commented Jun 10, 2022 •
edited
Loading

This PR updates some deprecated kube-state metrics, which are removed in more recent versions (see kubernetes/kube-state-metrics#1004), as below:

kube_pod_container_resource_requests_cpu_cores ->  kube_pod_container_resource_requests{resource="cpu"}

kube_pod_container_resource_requests_memory_bytes ->  kube_pod_container_resource_requests{resource="memory"}

@krithika369 krithika369 requested a review from a team June 10, 2022 02:12
leonlnj
leonlnj approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krithika369 krithika369 merged commit e396d8c into caraml-dev:main Jun 10, 2022
@krithika369 krithika369 deleted the update_deprecated_kube_metrics branch June 10, 2022 05:46
@terryyylim terryyylim mentioned this pull request Jun 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonlnj leonlnj leonlnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @leonlnj