-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): Remove authz middleware and update Turing API server, router, plugin dependencies #371
Merged
deadlycoconuts
merged 34 commits into
caraml-dev:main
from
deadlycoconuts:update_turing_api_server_dependencies
Apr 15, 2024
Merged
chore(api): Remove authz middleware and update Turing API server, router, plugin dependencies #371
deadlycoconuts
merged 34 commits into
caraml-dev:main
from
deadlycoconuts:update_turing_api_server_dependencies
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e72566
to
e871a99
Compare
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
deadlycoconuts
commented
Apr 8, 2024
leonlnj
reviewed
Apr 9, 2024
leonlnj
reviewed
Apr 9, 2024
leonlnj
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the heavy refactoring, left some minor comment but LGTM
leonlnj
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks LGTM
Thanks for the re-review. Gonna merge this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to caraml-dev/merlin#551, this MR basically bumps a couple of Go package dependencies used by the Turing API server, router, plugin, etc. The version of Go used in these components have also been bumped up from 1.20 to 1.22.
In addition to the general dependency upgrades, the authz middleware has been removed from the Turing API server entirely as it is no longer in use.
Main packages updated:
Some minor refactoring was performed on structs that may have changed or on functions called due to the changes in their expected arguments - these are annotated directly on the diffs.