Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: updates from v2.55.0 #2519

Merged
merged 1 commit into from
Aug 28, 2024
Merged

gh: updates from v2.55.0 #2519

merged 1 commit into from
Aug 28, 2024

Conversation

rsteube
Copy link
Member

@rsteube rsteube commented Aug 28, 2024

No description provided.

@rsteube rsteube merged commit 55ad98d into master Aug 28, 2024
6 checks passed
@ccoVeille
Copy link

How do you manage to notice such small wording difference?

A new option will be documented in the changelog. But this?

@rsteube rsteube deleted the gh-updates-v2.55.0 branch August 28, 2024 19:43
@rsteube
Copy link
Member Author

rsteube commented Aug 28, 2024

I've got a couple Scrapers for various frameworks.
GitHub CLI is open source and uses cobra.
Same as carapace so in this case all I have to do is:

add carapace as dependency

carapace.Gen(rootCmd)

compile and generate the yaml spec

gh _carapace spec > new.yaml

compare it with the current version using a diff tool to see which files changed (since this one is quite large)

carapace gh spec > old.yaml
meld new.yaml old.yaml

generate Go code from the spec

carapace --codegen new.yaml

and do a directory diff to adopt flag changes then add new completions if necessary

# completers/gh_completer/cmd 
meld /tmp/carapace-codegen-1165067547/ .

Plan is to open some PRs on the library projects for native spec support to make my life a bit easier.
But I want to flesh out some parts of the spec first.

@ccoVeille
Copy link

Very interesting. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants