Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flagset: use reflection for fork #118

Merged
merged 1 commit into from
Jan 13, 2023
Merged

flagset: use reflection for fork #118

merged 1 commit into from
Jan 13, 2023

Conversation

rsteube
Copy link
Member

@rsteube rsteube commented Jan 13, 2023

fix #71

@coveralls
Copy link

coveralls commented Jan 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3913062710

  • 20 of 62 (32.26%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.8%) to 48.485%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flag.go 17 31 54.84%
fork.go 3 31 9.68%
Files with Coverage Reduction New Missed Lines %
flag.go 12 62.75%
Totals Coverage Status
Change from base Build 3911064304: -4.8%
Covered Lines: 288
Relevant Lines: 594
💛 - Coveralls

@rsteube rsteube merged commit f528363 into master Jan 13, 2023
@rsteube rsteube deleted the pflag-reflection branch January 13, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support both spf13/pflag and rsteube/carapace-pflag
2 participants
@rsteube @coveralls