Fix encoding % sign breaking SVG background #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix22
requested changes
Sep 12, 2020
| function escapeXhtml(string) { | ||
| return string.replace(/%/g, '%25').replace(/#/g, '%23').replace(/\n/g, '%0A') | ||
| function escapeXhtml(string, escapePercentSign) { | ||
| if (escapePercentSign) { |
There was a problem hiding this comment.
@qw-in I'm pretty sure that instead of passing this in as a prop, we can just update the code path that converts to PNG to escape the percent sign, and don't convert that in the path used by SVGs.
|
@qw-in merged this to get the fix out the door, but feel free to come back to simplify it. I would prefer to avoid boolean options like Really appreciate your continued help here! It is a huge help to Carbon 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for the backgrounds breaking - guess I'll have to spend more time with this whole encoding issue than initially anticipated. Really hoping to find some time to put together those tests but it's been sunny here 😅
Escaping the
%sign was breaking some of the styles, specifically percentage units. But only for SVG 😢Closes #1095