Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cypress integration tests #162

Merged
merged 4 commits into from
Jan 20, 2018
Merged

Conversation

bahmutov
Copy link
Contributor

Partial solution to #136

  • background color changes
  • localStorage

See files cypress/integration for tests. To run locally npm run cy:open

screen shot 2018-01-18 at 10 04 17 pm

More info: uses Cypress.io test runner. I have also setup recording of tests and recorded a local run. See https://dashboard.cypress.io/#/projects/3tgxx3/runs/000f1338-9007-461a-9b9a-f483cbcaedec

screen shot 2018-01-18 at 10 05 26 pm

There are no failing tests but there is (although very quick) video

screen shot 2018-01-18 at 10 06 39 pm

Let me know if this makes sense, I can continue adding more tests.

@mfix22
Copy link
Contributor

mfix22 commented Jan 19, 2018

@bahmutov this is absolutely incredible! I want to pull this locally and run it to check it out before merging but this is awesome! 👍 Definitely want to eventually get this set up to run with a auto-now-deploy (see #159) and add it to our Travis job

@bahmutov
Copy link
Contributor Author

Perfect, glad this looks useful. Try it locally, ask me anything unclear either here or on https://twitter.com/bahmutov

PS: Have you seen https://github.com/bahmutov/now-pipeline for deploying with now from CI?

@mfix22
Copy link
Contributor

mfix22 commented Jan 19, 2018

@bahmutov thank you so much. This is huge for us!

Yes I have seen now-pipeline, but i totally forgot about it, and I'm clearly not doing to well over here #159 hahaha 😆 Once we expand our Now workflow I will probably move over too it.

Also do you know how to deploy for a certain team? --team=dawn is not working for me right now.

Finally, is there a way to transfer the Cypress project over to me? 😄

@bahmutov
Copy link
Contributor Author

Haha, I have not implemented team deploys in now-pipeline, but I did see your commits to get deploy to work ;) Keep up the good fight and if manual deploy is problematic, we can discuss using now-pipeline - it has some sweet features like testing unique url first, and switching alias only if tests pass.

So to transfer project - unfortunately our dashboard does not allow transferring project if we do not share an organization in common. For now I removed the project id from cypress.json, so if you start Cypress locally and click "Runs" you can just setup it for yourself.

screen shot 2018-01-19 at 9 46 53 am

Typically I would just make a public project under my own name

screen shot 2018-01-19 at 9 47 02 am

@mfix22
Copy link
Contributor

mfix22 commented Jan 20, 2018

This is so awesome. Thank you @bahmutov. I'm adding you to our contributors section, but let me know if you don't want to be included 😄

And I'm definitely going to configure now-pipeline once we get more e2e-tests written! Your software is amazing!

@mfix22 mfix22 merged commit 4078735 into carbon-app:master Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants