Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scatter): Add Scatter to the Angular package and storybook #301

Merged
merged 3 commits into from
Jul 10, 2019
Merged

feat(scatter): Add Scatter to the Angular package and storybook #301

merged 3 commits into from
Jul 10, 2019

Conversation

stanislavgeorgiev
Copy link
Contributor

Updates

Demo screenshot or recording

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@netlify
Copy link

netlify bot commented Jul 9, 2019 •
edited
Loading

Deploy preview for carbon-charts-core ready!

Built with commit c6f268c

https://deploy-preview-301--carbon-charts-core.netlify.com

@netlify
Copy link

netlify bot commented Jul 9, 2019 •
edited
Loading

Deploy preview for carbon-charts-vue ready!

Built with commit c6f268c

https://deploy-preview-301--carbon-charts-vue.netlify.com

@netlify
Copy link

netlify bot commented Jul 9, 2019 •
edited
Loading

Deploy preview for carbon-charts-react ready!

Built with commit c6f268c

https://deploy-preview-301--carbon-charts-react.netlify.com

@netlify
Copy link

netlify bot commented Jul 9, 2019 •
edited
Loading

Deploy preview for carbon-charts-angular ready!

Built with commit c6f268c

https://deploy-preview-301--carbon-charts-angular.netlify.com

theiliad
theiliad requested changes Jul 9, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
packages/angular/stories/scatter.stories.ts Outdated Show resolved Hide resolved
packages/angular/stories/scatter.stories.ts Outdated Show resolved Hide resolved
theiliad
theiliad requested changes Jul 10, 2019
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for 1 thing 💯

README.md Outdated Show resolved Hide resolved
cal-smith
cal-smith approved these changes Jul 10, 2019
View reviewed changes
packages/angular/src/scatter-chart.component.ts
* Most functions just call their equivalent from the chart library.
*/
@Component({
selector: "n-scatter-chart",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally never caught this ... we'll want to switch the prefix to either ibm- (to match carbon-angular) or c- (for carbon) ... the easiest way going forwards will be "ibm-scatter-chart, n-scatter-chart" (or whatever prefix) until we hit v1.

Doesn't stop this PR, but just something we should sort out sooner rather than later.

@theiliad theiliad merged commit 562d7ae into carbon-design-system:master Jul 10, 2019
@theiliad
Copy link
Member

thanks @stanislavgeorgiev

@stanislavgeorgiev
Copy link
Contributor Author

Cool, my first contribution to Charts 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cal-smith cal-smith cal-smith approved these changes

@theiliad theiliad theiliad approved these changes

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scatter chart missing in Angular package
3 participants
@stanislavgeorgiev @theiliad @cal-smith