We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<p>
Original report: #1908 (comment)
Svelte 5 yields a compiler error for <Link> because <div> is an invalid descendent of <p>, which is correct as per W3 spec.
<Link>
<div>
I recommend we align behaviour with Carbon React:
<a aria-disabled="true">
Reference:
carbon-components-svelte/src/Link/Link.svelte
Lines 37 to 60 in 96aef17
Demo: https://stackblitz.com/edit/sveltejs-kit-template-default-mxnwjf?file=src%2Froutes%2F%2Bpage.svelte
Screenshot:
The text was updated successfully, but these errors were encountered:
Yes, I think it makes sense to fix this for <v1 if it's blocking Svelte 5 usage.
Sorry, something went wrong.
fix(link)!: do not render p for disabled link
p
0b7aca1
Closes #1924 Svelte 5 will not compile if `div` is nested inside `p` element. Refactor Link to render an `a` instead of `p` when disabled.
8bffc17
Fix was released in v0.83.0.
Successfully merging a pull request may close this issue.
Original report: #1908 (comment)
Issue
Svelte 5 yields a compiler error for
<Link>
because<div>
is an invalid descendent of<p>
, which is correct as per W3 spec.I recommend we align behaviour with Carbon React:
<a aria-disabled="true">
(<p>
has different layout behaviour)Reference:
carbon-components-svelte/src/Link/Link.svelte
Lines 37 to 60 in 96aef17
Reproduction
Demo: https://stackblitz.com/edit/sveltejs-kit-template-default-mxnwjf?file=src%2Froutes%2F%2Bpage.svelte
Screenshot:
The text was updated successfully, but these errors were encountered: