Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding of Input Element #752

Open
Tracked by #1888
pakorn-tp opened this issue Jul 16, 2021 · 3 comments
Open
Tracked by #1888

Padding of Input Element #752

pakorn-tp opened this issue Jul 16, 2021 · 3 comments

Comments

@pakorn-tp
Copy link

pakorn-tp commented Jul 16, 2021

Padding of Input element when not have title is not consistency

  • Select and TextInput
@metonym
Copy link
Collaborator

metonym commented Jul 16, 2021

Can you attach a screenshot instead of linking to a separate site?

@pakorn-tp
Copy link
Author

Screen-Shot-2564-07-16-at-11-25-59

@theetrain theetrain mentioned this issue Jan 13, 2024
8 tasks
@SimpleProgrammingAU
Copy link
Contributor

If you use the noLabel prop on the Select component, the label margin isn't rendered resolving this issue.

There is a disconnect between how the Select component works when compared to the TextInput component. TextInput won't render the label margin if Boolean(labelText) === false.

My personal preference is to go with the way the TextInput works because an empty label doesn't render the full height of a label if it were populated (i.e. it won't line up with other inline inputs that do have labels).

I have not made any updates to TextInput based on this issue so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants