Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput v11 #1888

Closed
8 tasks done
Tracked by #1629
theetrain opened this issue Jan 13, 2024 · 4 comments
Closed
8 tasks done
Tracked by #1629

TextInput v11 #1888

theetrain opened this issue Jan 13, 2024 · 4 comments
Labels
v11 Carbon v11 feature

Comments

@theetrain
Copy link
Collaborator

theetrain commented Jan 13, 2024 •
edited
Loading

Spun off from #1629
@theetrain theetrain mentioned this issue Jan 13, 2024
Open
@theetrain theetrain changed the title TextInput TextInput v11 Jan 13, 2024
@theetrain theetrain added the v11 Carbon v11 feature label Jan 13, 2024
@theetrain
Copy link
Collaborator Author

@SimpleProgrammingAU I captured as many outcomes as I could above. Thank you for contributing!

SimpleProgrammingAU pushed a commit to SimpleProgrammingAU/carbon-components-svelte that referenced this issue Jan 14, 2024
Added pointer events, updated skeleton TextInput v11 carbon-design-sy…
630451c 
…stem#1888
@SimpleProgrammingAU SimpleProgrammingAU mentioned this issue Jan 14, 2024
Merged
@SimpleProgrammingAU
Copy link
Contributor

SimpleProgrammingAU commented Jan 14, 2024 •
edited
Loading

@theetrain do you wanna add PasswordInput to this issue since it's in the same directory?

@theetrain
Copy link
Collaborator Author

@SimpleProgrammingAU I think PasswordInput can be handled separately since it doesn't share co-dependencies with TextInput; this way PRs can be kept small.

@theetrain theetrain mentioned this issue Jan 14, 2024
Open
2 tasks
theetrain added a commit that referenced this issue Jan 17, 2024
@SimpleProgrammingAU @theetrain
feat!: TextInput v11 Styles (#1889)
c436dbd 
* Initial commit

* Fixes [FluidForm] TextInput error icon is misplaced #1667

* Contributes to [TextInput] helperText enhancements #1633

* Adopts Standardize props and events #1621

* Added slots for Standardize props and events #1621

* Added pointer events, updated skeleton TextInput v11 #1888

* Address a bug in the word counter regex

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Explicitly define default value for `size`

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Adopted suggested changes

* Updated `TextInput.test`; added forgotten files from previous

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
@theetrain theetrain mentioned this issue Jan 17, 2024
Open
2 tasks
@theetrain
Copy link
Collaborator Author

This was released in v1.0.0-next.1.

metonym pushed a commit that referenced this issue Mar 23, 2024
@SimpleProgrammingAU @theetrain @metonym
feat!: TextInput v11 Styles (#1889)
9efe525 
* Initial commit

* Fixes [FluidForm] TextInput error icon is misplaced #1667

* Contributes to [TextInput] helperText enhancements #1633

* Adopts Standardize props and events #1621

* Added slots for Standardize props and events #1621

* Added pointer events, updated skeleton TextInput v11 #1888

* Address a bug in the word counter regex

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Explicitly define default value for `size`

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Adopted suggested changes

* Updated `TextInput.test`; added forgotten files from previous

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v11 Carbon v11 feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimpleProgrammingAU @theetrain