Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FluidForm] TextInput error icon is misplaced #1667

Open
Tracked by #1888
theetrain opened this issue Feb 26, 2023 · 0 comments
Open
Tracked by #1888

[FluidForm] TextInput error icon is misplaced #1667

theetrain opened this issue Feb 26, 2023 · 0 comments
Labels
bug Something isn't working v11 Carbon v11 feature

Comments

@theetrain
Copy link
Collaborator

When rendering an invalid TextInput, its icon is misaligned:

image

This may potentially impact other inputs as well: PasswordInput, NumberInput, DateInput, TextArea.

Discovered in #1666
@theetrain theetrain added bug Something isn't working v11 Carbon v11 feature labels Feb 26, 2023
@theetrain theetrain mentioned this issue Jan 13, 2024
Closed
8 tasks
SimpleProgrammingAU pushed a commit to SimpleProgrammingAU/carbon-components-svelte that referenced this issue Jan 14, 2024
Fixes [FluidForm] TextInput error icon is misplaced carbon-design-sys…
ae686c2 
…tem#1667
@SimpleProgrammingAU SimpleProgrammingAU mentioned this issue Jan 14, 2024
Merged
theetrain added a commit that referenced this issue Jan 17, 2024
@SimpleProgrammingAU @theetrain
feat!: TextInput v11 Styles (#1889)
c436dbd 
* Initial commit

* Fixes [FluidForm] TextInput error icon is misplaced #1667

* Contributes to [TextInput] helperText enhancements #1633

* Adopts Standardize props and events #1621

* Added slots for Standardize props and events #1621

* Added pointer events, updated skeleton TextInput v11 #1888

* Address a bug in the word counter regex

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Explicitly define default value for `size`

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Adopted suggested changes

* Updated `TextInput.test`; added forgotten files from previous

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
metonym pushed a commit that referenced this issue Mar 23, 2024
@SimpleProgrammingAU @theetrain @metonym
feat!: TextInput v11 Styles (#1889)
9efe525 
* Initial commit

* Fixes [FluidForm] TextInput error icon is misplaced #1667

* Contributes to [TextInput] helperText enhancements #1633

* Adopts Standardize props and events #1621

* Added slots for Standardize props and events #1621

* Added pointer events, updated skeleton TextInput v11 #1888

* Address a bug in the word counter regex

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Explicitly define default value for `size`

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Adopted suggested changes

* Updated `TextInput.test`; added forgotten files from previous

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v11 Carbon v11 feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theetrain