feat!: remove as
prop in favor of svelte:element
#1628
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was developed initially to address #1605. It removes the
as
prop, which was added beforesvelte:element
was supported in Svelte. The purpose is to allow the consumer to customize the element tag.However, this should not be merged since it has a flaw.
The issue is that
$$restProps
are spread to the element; the tag attributes in the generated types should be generic to match the tag. This is a limitation of sveld, which does not support generics in props.Perhaps another reason to switch to TypeScript +
@sveltejs/package
(#1616)