-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon v11 integration #1636
Carbon v11 integration #1636
Conversation
@metonym I've been trying to get I suppose sveld can derive documentation from the source files, even though I have it configured to read from |
@theetrain I think import assertions require Node >=v17.5 since they're still an experimental feature. I'm using v16 and had to run: node --experimental-json-modules scripts/build-docs.js The script ran with a
I had to then manually specify a + "svelte": "src/carbon-components-svelte/index.js", After these steps, the script ran successfully. |
That helped, thanks! I use Node 18, and took for granted this feature. Perhaps editing carbon-components-svelte can be done with Node 18, but we can allow users to use Node 16 when consuming the package? I could also make these imports backwards-compatible using the tip here: https://stackoverflow.com/a/74504130/2545443 Other observations:
|
0d1ff59
to
3f188ce
Compare
- Configure as ES module - Add svelte as peerDependency - add Vite and vite-preprocess to inline imported SCSS
Support sass and typescript
Should be separate PRs
Update docs with sveld
Build npm package before testing
* feat(button): adopt v11 styles - forward focus and blur events - provide button role for custom elements using 'as' BREAKING CHANGE: danger-tertiary and danger-ghost props were renamed to danger--tertiary and danger--ghost BREAKING CHANGE: buttons now have a larger minimum width * test: update button test
22d2bef
to
6fc0ab3
Compare
Currently carbon Ui-Shell is totally broken , this PR will hopefully fix it. Please make carbon design usable. |
e7485c4
to
417102d
Compare
Superseded by #1881 |
Closes #1629
Closes #1616
feat/carbon-v11
branch. We can make incremental releases to thenext
tag.This PR is meant to track and discuss the progress in #1629.
Changes
General
@sveltejs/package
for building the distributable package as ESM, which also precompiles TypeScript and SCSS/docs
Button