Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback issue preventFormSubmission #11023

Merged

Conversation

deathcave
Copy link
Contributor

Related Ticket(s)

Noitce & Choice w3 Publisher

Description

Notice & Choice is a legally required component to create a form where IBM collects its customer information.
This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences.

Changelog

New

  • A new web component to create notice & choice user interface.

Changed

  • Fixed call-back function preventFormSubmission

Removed

  • Postal option removed from new notice and choice version

@deathcave deathcave requested a review from a team as a code owner October 11, 2023 13:52
@deathcave
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@sanjitbauli sanjitbauli added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Oct 11, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 11, 2023

@deathcave deathcave force-pushed the FixPreventFormSubmission branch from 52b2ed2 to e1583a5 Compare October 12, 2023 03:33
@deathcave deathcave force-pushed the FixPreventFormSubmission branch from 3111ee8 to 891f9da Compare October 13, 2023 06:23
@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Oct 14, 2023
@kodiakhq kodiakhq bot merged commit 1e06611 into carbon-design-system:main Oct 14, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants