Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Country Based text value #11038

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Fixed Country Based text value #11038

merged 3 commits into from
Oct 18, 2023

Conversation

deathcave
Copy link
Contributor

Related Ticket(s)

Noitce & Choice w3 Publisher

Description

Notice & Choice is a legally required component to create a form where IBM collects its customer information.
This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences.

Changelog

New

  • A new web component to create notice & choice user interface.

Changed

  • Fixed call-back function country based text

Removed

  • Postal option removed from new notice and choice version

@deathcave deathcave requested a review from a team as a code owner October 16, 2023 10:21
@deathcave
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11038/index.html

Built with commit: c202e69b899d9be85c13d5bcf2f32be1b2f22703

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11038/index.html

Built with commit: c202e69b899d9be85c13d5bcf2f32be1b2f22703

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11038/index.html

Built with commit: c202e69b899d9be85c13d5bcf2f32be1b2f22703

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11038/index.html

Built with commit: c202e69b899d9be85c13d5bcf2f32be1b2f22703

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11038/index.html

Built with commit: c202e69b899d9be85c13d5bcf2f32be1b2f22703

@sanjitbauli sanjitbauli added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Oct 16, 2023
@kennylam
Copy link
Member

@deathcave You need to run a yarn format from project root. Are you bypassing the pre-commit hooks? The formatting should happen automatically to staged files.

@deathcave
Copy link
Contributor Author

@deathcave You need to run a yarn format from project root. Are you bypassing the pre-commit hooks? The formatting should happen automatically to staged files.

Fixed format issue

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11038/index.html

Built with commit: c202e69b899d9be85c13d5bcf2f32be1b2f22703

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Oct 18, 2023
@kodiakhq kodiakhq bot merged commit baa7af3 into carbon-design-system:main Oct 18, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@sanjitbauli sanjitbauli sanjitbauli approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deathcave @ibmdotcom-bot @kennylam @sanjitbauli