Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice Choice web component fine tuning #11515

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Notice Choice web component fine tuning #11515

merged 3 commits into from
Feb 13, 2024

Conversation

deathcave
Copy link
Contributor

Related Ticket(s)

Noitce & Choice w3 Publisher

Description

Notice & Choice is a legally required component to create a form where IBM collects its customer information.
This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences.

Changelog

New

Changed

  • Notice Choice web component fine tuned.

Removed

@deathcave deathcave requested a review from a team as a code owner February 9, 2024 15:14
@deathcave deathcave requested review from emyarod and ariellalgilmore and removed request for a team February 9, 2024 15:14
@deathcave
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11515/index.html

Built with commit: f3926c96483de16fcaed1d013d50f30e86ed3051

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11515/index.html

Built with commit: f3926c96483de16fcaed1d013d50f30e86ed3051

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11515/index.html

Built with commit: f3926c96483de16fcaed1d013d50f30e86ed3051

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11515/index.html

Built with commit: f3926c96483de16fcaed1d013d50f30e86ed3051

@kennylam kennylam added package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge labels Feb 13, 2024
@kodiakhq kodiakhq bot merged commit b484efc into carbon-design-system:main Feb 13, 2024
12 of 19 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@deathcave @kennylam
Notice Choice web component fine tuning (carbon-design-system#11515)
0fd1351 
### Related Ticket(s)

[Noitce & Choice w3 Publisher](https://w3.ibm.com/w3publisher/urx/notice-and-choice-v23)

### Description

Notice & Choice is a legally required component to create a form where IBM collects its customer information.
This section shows the specific product's legal links, terms, and conditions. Along with this, it collects users' consent regarding communication preferences.

### Changelog

**New**

**Changed**

-  Notice Choice web component fine tuned.

**Removed**

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deathcave @ibmdotcom-bot @kennylam