Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storybook): content-block-card storybook link fix #11692

Merged
merged 4 commits into from
Apr 5, 2024
Merged

chore(storybook): content-block-card storybook link fix #11692

merged 4 commits into from
Apr 5, 2024

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Apr 2, 2024

Description

Deprecated component name in Storybook story was causing the components to render incorrectly.

Changelog

Changed

  • use c4d-card-footer instead of c4d-card-cta-footer

@kennylam kennylam added package: web components Work necessary for the IBM.com Library web components package storybook labels Apr 2, 2024
@kennylam kennylam requested a review from a team as a code owner April 2, 2024 16:00
@kennylam kennylam requested review from ariellalgilmore and sangeethababu9223 and removed request for a team April 2, 2024 16:00
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 2, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11692/index.html

Built with commit: c4b2a68e552f17d1169d63dabcfe256a472f5bf7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 2, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11692/index.html

Built with commit: c4b2a68e552f17d1169d63dabcfe256a472f5bf7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 2, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11692/index.html

Built with commit: c4b2a68e552f17d1169d63dabcfe256a472f5bf7

ariellalgilmore
ariellalgilmore reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good nice cleanup! Just a few comments maybe out of scope for this PR

packages/web-components/src/components/cta/__stories__/cta.stories.ts Outdated Show resolved Hide resolved
packages/web-components/src/components/content-section/__stories__/README.stories.mdx Outdated Show resolved Hide resolved
...b-components/src/components/content-block-simple/__stories__/content-block-simple.stories.ts Outdated Show resolved Hide resolved
ariellalgilmore
ariellalgilmore approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Apr 5, 2024
@kodiakhq kodiakhq bot merged commit c5eeb3a into carbon-design-system:main Apr 5, 2024
12 of 14 checks passed
@kennylam kennylam deleted the chore/card-group-storybook-link-fix branch April 5, 2024 00:55
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @ariellalgilmore