Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slug): ai slug updates #11716

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat(slug): ai slug updates #11716

merged 4 commits into from
Apr 15, 2024

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Apr 11, 2024 •
edited
Loading

Related Ticket(s)

Closes #11674

Description

Following changes from Carbon core (carbon-design-system/carbon#15943) to update the AI slug. This sets the hollow variation to default.

Screenshot 2024-04-11 at 4 24 29 PM

Changelog

Changed

  • set hollow variation styles to be the default slug styles
  • adjust box-shadow values to match changes from Carbon

Removed

  • remove references to the hollow slug variation
  • removed the dot-type property from slug

@annawen1 annawen1 requested a review from a team as a code owner April 11, 2024 20:16
@annawen1 annawen1 requested review from emyarod and ariellalgilmore and removed request for a team April 11, 2024 20:16
@annawen1 annawen1 added area: AI Used to filter issues in the Carbon for AI project. package: carbon web components labels Apr 11, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11716/index.html

Built with commit: 269c9df6525cc2e33e1f415e5df84fcff33293eb

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11716/index.html

Built with commit: 269c9df6525cc2e33e1f415e5df84fcff33293eb

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11716/index.html

Built with commit: 269c9df6525cc2e33e1f415e5df84fcff33293eb

emyarod
emyarod approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@annawen1 annawen1 added Ready to merge Label for the pull requests that are ready to merge and removed Ready to merge Label for the pull requests that are ready to merge labels Apr 12, 2024
@kodiakhq kodiakhq bot merged commit e9fa12f into carbon-design-system:main Apr 15, 2024
12 of 14 checks passed
@annawen1 annawen1 deleted the feat/update-slug-ai-updates branch April 15, 2024 18:38
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.8.0.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.8.0.

@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.8.0.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@annawen1
feat(slug): ai slug updates (carbon-design-system#11716)
4451321 
### Related Ticket(s)

Closes #[11674](carbon-design-system#11674)

### Description

Following changes from Carbon core (carbon-design-system/carbon#15943) to update the AI slug. This sets the `hollow` variation to default.

<img width="716" alt="Screenshot 2024-04-11 at 4 24 29 PM" src="https://github.com/carbon-design-system/carbon-for-ibm-dotcom/assets/54281166/11b971cf-70dd-406e-87f2-8bc824c92d28">


### Changelog

**Changed**

- set `hollow` variation styles to be the default slug styles
- adjust box-shadow values to match changes from Carbon

**Removed**

- remove references to the `hollow` slug variation
- removed the dot-type property from slug

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawen1 @ibmdotcom-bot @emyarod @ariellalgilmore