-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): component renders multiple headings #12030
fix(card): component renders multiple headings #12030
Conversation
Deploy preview created for package Built with commit: e2f6a870d551738254098b129c30359763d4cbb6 |
Deploy preview created for package Built with commit: dfca2492818647946b51b239a91be32436ca56b0 |
Deploy preview created for package Built with commit: 8de6b855450686759c3effc6f0ddd84b9d596820 |
Deploy preview created for package Built with commit: 8de6b855450686759c3effc6f0ddd84b9d596820 |
Hey @Valentin-Sorin-Nicolae , two notes on this:
|
Hey @RichKummer thanks for the review.
I'm not sure this is the case. What we're calling "caption" here, is really the Does that make sense? As I read over the issue and code, it seems to me that the naming of |
@m4olivei Ah okay, if that is the case then I think it's fine to have The name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well. Will add the Ready to Merge label.
e715924
into
carbon-design-system:main
Hey there! This issue/pull request was referenced in recently released v2.14.0. |
Related Ticket(s)
ADCMS-6175
Closes #12000
Description
C4DCard and C4DCardCTA both have a
_renderHeading()
method that returns the following:If these components are authored with a element within them, it's automatically assigned to slot="heading". This leads to cards with multiple headings, each with their own minimum of 64px of margin-bottom.
Changed